Connect terms to their source #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than assume this only runs on `$attributes`, we need to connect the $source to it's given `$tax_object` that is passed instead.
kidunot89
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
@jacobarriola Got it work locally with a taxonomy created with CPT-UI. Good work 👍.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Ensures that connections between all products and their terms are properly connected, not just product attributes.
The previous PR (#346) mistakenly assumed that all connections were attributes. What we should be grabbing is the terms instead of the attributes.
Does this close any currently open issues?
#348
#345
Any relevant logs, error output, GraphiQL screenshots, etc?
See issues.
Where has this been tested?
WooCommerce: 3.6
WordPress Version: 5.2