Guard against false terms when plucking IDs #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_the_terms` can return `false`, which causes errors when running anything other than an array in `wp_list_pluck`. Related to wp-graphql#363.
kidunot89
requested changes
Nov 10, 2020
There was a problem hiding this comment.
@jacobarriola Great work on this. I'm sorry it took so long for me to really look at this problem.
Co-authored-by: Geoffrey K Taylor <geoffrey.taylor@outlook.com>
kidunot89
requested changes
Nov 10, 2020
| $resolver = new TermObjectConnectionResolver( $source, $args, $context, $info, $tax_object->name ); | ||
|
|
||
|
|
||
| $term_ids = \wc_get_object_terms( $object_id, $taxonomy, 'term_id' ); |
There was a problem hiding this comment.
My bad 😅, it should be $tax_object->name not $taxonomy.
There was a problem hiding this comment.
😆 yup, I saw that after too. It's corrected now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_the_termscan returnfalse, which causes errors when running anything other than an array inwp_list_pluck. Related to #363.What does this implement/fix? Explain your changes.
Fixes an
ErrorException Invalid argument supplied for foreach()when we pass anything other than an array towp_list_pluck()when connecting a term to a product.Does this close any currently open issues?
#363
Any relevant logs, error output, GraphiQL screenshots, etc?
See the issue.