Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the username field optional in registerCustomer mutation #381

Conversation

kidunot89
Copy link
Member

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

Extends #340

  • Adds testRegisterMutationWithoutAnyInfo test to the CustomerMutationsTest test case.

@HiepVu511 ☝️ Good work on this 👍

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Ubuntu 20.04

WordPress Version: 5.5.3

@kidunot89 kidunot89 added the bugfix Implements bugfix label Nov 23, 2020
@kidunot89 kidunot89 changed the title Make the username field optional in registerCustomer Mutation Make the username field optional in registerCustomer mutation Nov 23, 2020
@kidunot89 kidunot89 merged commit 8591ea1 into wp-graphql:develop Nov 23, 2020
@kidunot89 kidunot89 deleted the feature/register-customer-without-username branch November 23, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants