implements metadata for customer register and update #402
Conversation
|
Looks like the linting issues that this PR is failing on aren't related to the changes in this PR, is that correct? I really need this feature, any chance of merging it? I'm happy to help in any way I can to speed this up? |
|
@PaperPlaneSoftware feel free to check whatever you can add. I'm still waiting owners to review my PR. Hope they' will find some time, this library is so much great ! |
|
Hi! I also need this feature! I'm using custom fields (saved as meta data in Worpdress) in the billing and shipping form and it's the only way to update this information! @believelody Can we help you to speed this up? Thanks for your work by the way 馃殌 |
|
@aresrioja10 sure, feel free to check what you can do. It seems the big problem is lint code. Still waiting for @kidunot89 to check if something is wrong. |
There was a problem hiding this comment.
@believelody @aresrioja10 I'm sorry for the delayed response been fixing a few fires with CI here and there. To answer your question the hold up is testing.
I can't add new code without ensuring its covered by the tests, too much risk involved with sites in production. This typically means for every new PR I have to usually pull down the PR branch, add a new test if the incoming changes warrant it and this change definitely warrants a test.
I have two other PRs to do before this one, but if one of you adds a working test for the changes to this test file. I can expedite this PR immediately.
kidunot89
force-pushed
the
feature/customer-metadata
branch
from
7bcc5af
to
6adfc19
Compare
There was a problem hiding this comment.
@believelody @aresrioja10 With the test I added, this PR is ready for merging as soon as CI passes.
| $query = ' | ||
| mutation( $input: UpdateCustomerInput! ) { | ||
| updateCustomer( input: $input ) { | ||
| customer { | ||
| databaseId | ||
| metaData { | ||
| key | ||
| value | ||
| } | ||
| } | ||
| } | ||
| } | ||
| '; | ||
| $variables = array( | ||
| 'input' => array( | ||
| 'clientMutationId' => 'some_id', | ||
| 'id' => \GraphQLRelay\Relay::toGlobalId( 'customer', $user->ID ), | ||
| 'metaData' => array( | ||
| array( | ||
| 'key' => 'test_meta_key', | ||
| 'value' => 'new_meta_value', | ||
| ), | ||
| ), | ||
| ) | ||
| ); | ||
|
|
||
| $actual = graphql( compact( 'query', 'variables' ) ); | ||
| codecept_debug( $actual ); | ||
|
|
||
| $expected = array( | ||
| 'data' => array( | ||
| 'updateCustomer' => array( | ||
| 'customer' => array( | ||
| 'databaseId' => $user->ID, | ||
| 'email' => 'user@woographql.test', | ||
| 'metaData' => array( | ||
| array( | ||
| 'key' => 'test_meta_key', | ||
| 'value' => 'new_meta_value', | ||
| ) | ||
| ) | ||
| ), | ||
| ), | ||
| ), | ||
| ); | ||
|
|
||
| $this->assertEquals( $expected, $actual ); | ||
|
|
||
| /** | ||
| * Assertion Three | ||
| * | ||
| * Test "metaData" input field with "updateCustomer" mutation on the session user. | ||
| */ | ||
| $query = ' | ||
| mutation( $input: UpdateCustomerInput! ) { | ||
| updateCustomer( input: $input ) { | ||
| customer { | ||
| id | ||
| metaData { | ||
| key | ||
| value | ||
| } | ||
| } | ||
| } | ||
| } | ||
| '; | ||
| $variables = array( | ||
| 'input' => array( | ||
| 'clientMutationId' => 'some_id', | ||
| 'metaData' => array( | ||
| array( | ||
| 'key' => 'test_meta_key', | ||
| 'value' => 'test_meta_value', | ||
| ), | ||
| ), | ||
| ) | ||
| ); | ||
|
|
||
| $actual = graphql( compact( 'query', 'variables' ) ); | ||
| codecept_debug( $actual ); | ||
|
|
||
| $expected = array( | ||
| 'data' => array( | ||
| 'updateCustomer' => array( | ||
| 'customer' => array( | ||
| 'id' => 'guest', | ||
| 'metaData' => array( | ||
| array( | ||
| 'key' => 'test_meta_key', | ||
| 'value' => 'test_meta_value', | ||
| ) | ||
| ) | ||
| ), | ||
| ), | ||
| ), | ||
| ); | ||
|
|
||
| $this->assertEquals( $expected, $actual ); | ||
| } |
There was a problem hiding this comment.
@believelody @aresrioja10 Test added. Please use this as a reference in future when making PRs introducing logic that needs to be tested.
There was a problem hiding this comment.
Thank you so much @kidunot89.Don't worry for your delayed reply, I will use your test code and learn better about that.
There was a problem hiding this comment.
@kidunot89 Thank you so much! I'm gonna test it right now :)
kidunot89
added
enhancement
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
馃毃Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
Allow Customer to include metadata in registerCustomer mutation and updateCustomer mutation
Does this close any currently open issues?
No
Any relevant logs, error output, GraphiQL screenshots, etc?
Metadata in registerCustomer mutation
Metadata in customers query
Metadata in updateCustomer mutation
Any other comments?
Tell me if this enough and meet your requirements. Inspired by woocommerce-rest-api customer register feature
Where has this been tested?
Operating System: Ubuntu 18.04.5
WordPress Version: 5.5.3