Session Transaction Manager bugfixes and enhancements #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The customer id is stored in the the session_handler instance. As a result the same transient was getting set for all users, which was causing errors when a hanging transaction was left.
The session data (snapshot) is a property of the session_handler, not of the existing instance. As a result, the snapshot was always returning null.
There are instances where a stale transaction stays around do to an error in the mutation. As a result, the recursive update_transaction_queue method will continue to run over and over, causing an inifinte loop and potentially crashing the server. This attempts to add a timestamp once the transaction is validated when checking via the timestamp and will remove it from the queue.
kidunot89
force-pushed
the
bugfix/session-transaction-manager
branch
from
44f8b12
to
b4a158b
Compare
kidunot89
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What does this implement/fix? Explain your changes.
This PR intends to add enhancements and bug fixes to the Session Transaction Manager. Specifically:
nullvalue for_customer_idwhen setting/getting the transients. As is all transients are getting set to the same id. As a result, if one error occurs, that makes it an error for all subsequent requests.nullvalue when setting$snapshotin the transaction.$snapshotisn't used at the moment, but it's incorrectly getting set.Does this close any currently open issues?
#494
Where has this been tested?