Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Coupon_Connection_Resolver" deprecated. #497

Merged

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented May 19, 2021

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Coupon_Connection_Resolver class deprecated and will be removed in release v0.11.x. The "PostObjectConnectionResolver" class and the hooks contained within are used in it's place. Any remaining unique code in-use has be relocated to the class-coupons.php.
  • **CouponQueriesTest.php` has be refactored to use the WPGraphQLTestcase library.

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version: 0.8.1
  • WPGraphQL Version: 1.3.8
  • WordPress Version: 5.7.2
  • WooCommerce Version: 5.3

@kidunot89 kidunot89 added enhancement New feature or request bugfix Implements bugfix labels May 19, 2021
@kidunot89 kidunot89 requested a review from jasonbahl May 19, 2021 23:53
@w3bdesign w3bdesign mentioned this pull request May 20, 2021
@kidunot89 kidunot89 merged commit 2d45d6d into wp-graphql:develop May 30, 2021
@kidunot89 kidunot89 deleted the feature/coupon-connection-upgrade branch May 30, 2021 18:57
@kidunot89 kidunot89 removed the enhancement New feature or request label Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant