Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated function nonce_user_logged_out #547

Conversation

kpoelhekke
Copy link
Contributor

@kpoelhekke kpoelhekke commented Sep 5, 2021

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

Currently when the wp-graphql-woocommerce plugin is activated I'm getting CORS errors during clientside queries. I've tracked the the problem down and I found out that the plugin is still using a deprecated function that causes it.

Since Woocommerce v5.3.0 the nonce_user_logged_out function used in the session handler is deprecated. This PR replaces that function with the new maybe_update_nonce_user_logged_out.

Does this close any currently open issues?

Not that I know of.

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version: 0.10.3
  • WPGraphQL Version: 1.6.4
  • WordPress Version: 5.8.0
  • WooCommerce Version: 5.6.0

@kpoelhekke kpoelhekke changed the title Use maybe_update_nonce_user_logged_out instead of deprecated nonce_us… Replace deprecated function nonce_user_logged_out Sep 5, 2021
@codeclimate
Copy link

codeclimate bot commented Sep 8, 2021

Code Climate has analyzed commit d1a3e22 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 77.0% (0.0% change).

View more on Code Climate.

Copy link
Member

@kidunot89 kidunot89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpoelhekke Thanks for this 👍🏿

@kidunot89 kidunot89 merged commit 5fe732d into wp-graphql:develop Sep 8, 2021
@kidunot89 kidunot89 added the bugfix Implements bugfix label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants