Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: applied coupon description field added #572

Merged

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Oct 22, 2021

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Adds description field to AppliedCoupon type.
  • Update CartMutationsTest to test new field.

Does this close any currently open issues?

Resolves #548

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 added enhancement New feature or request new fields Feature adds new fields to existing types labels Oct 22, 2021
@kidunot89 kidunot89 self-assigned this Oct 22, 2021
'type' => 'String',
'description' => __( 'Description of applied coupon', 'wp-graphql-woocommerce' ),
'resolve' => function( $source, array $args ) {
$coupon = new \WC_Coupon( $source );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing class import via use statement (line '625', column '22').

@codeclimate
Copy link

codeclimate bot commented Oct 23, 2021

Code Climate has analyzed commit ebf2122 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 2
Clarity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.0% (0.0% change).

View more on Code Climate.

@kidunot89 kidunot89 merged commit a3dfa80 into wp-graphql:develop Oct 23, 2021
@kidunot89 kidunot89 deleted the feature/applied-coupon-description branch October 23, 2021 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new fields Feature adds new fields to existing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return description of coupon from appliedCoupon
1 participant