Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Account URL added to Auth URLs, and VariationAttribute connection fixed #755

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Jun 26, 2023

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Adds accountUrl and accountNonce to the Authorizing URLs option.
  • Fixes issues related to auth URLs usage.
  • Fixes the simpleProduct's defaultAttributes field.

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 merged commit 60711aa into wp-graphql:develop Jul 3, 2023
11 checks passed
@kidunot89 kidunot89 deleted the feat/auth-url-account-page branch July 3, 2023 07:35
@kidunot89 kidunot89 self-assigned this Jul 3, 2023
@kidunot89 kidunot89 added enhancement New feature or request bugfix Implements bugfix labels Jul 3, 2023
@kidunot89 kidunot89 changed the title feat: Account URL added to Auth URLs. fix: Account URL added to Auth URLs, and VariationAttribute connection fixed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant