-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cleanup useless variables and ternaries #766
fix: cleanup useless variables and ternaries #766
Conversation
'disabled' => $enable_auth_urls_hardcoded ? true : false, | ||
'sanitize_callback' => function( $value ) { | ||
'disabled' => $enable_auth_urls_hardcoded, | ||
'sanitize_callback' => static function( $value ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentionally leaked to prevent merge conflicts with #764
$item = \WC()->cart->get_cart_item( $payload['key'] ); | ||
|
||
return $item; | ||
'resolve' => static function ( $payload ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentionally leaked to prevent merge conflicts with #764
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
36ad4ba
to
30d43fa
Compare
Your checklist for this pull request
Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.
🚨Please review the guidelines for contributing to this repository.
What does this implement/fix? Explain your changes.
This PR cleans up various useless variables and unnecessary ternaries from the codebase.
Branch is based off of #763, which should be merged first.
Does this close any currently open issues?
…
Any relevant logs, error output, GraphiQL screenshots, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Any other comments?
Several unused variables remain in the codebase, where its unclear at a glance if their lack of use is intentional or a bug. They will be picked up by WPGraphQL Coding Standards and can be evaluated/removed/refactored separately.
Where has this been tested?