Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Session transaction queue fix #832

Merged

Conversation

kidunot89
Copy link
Member

@kidunot89 kidunot89 commented Dec 27, 2023

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix/devops branch (right side). Don't pull request from your master!
  • Have you ensured/updated that CLI tests to extend coverage to any new logic. Learn how to modify the tests here.

What does this implement/fix? Explain your changes.

  • Changes hook used for WPGraphQL\WooCommerce\Utils\Session_Transaction_Manager::pop_transaction_id to graphql_mutation_response
  • woographql_session_transaction_complete hook added to the end of WPGraphQL\WooCommerce\Utils\Session_Transaction_Manager::pop_transaction_id
  • Changes hook used for WPGraphQL\WooCommerce\Utils\QL_Session_Handler::save_if_dirty() to woographql_session_transaction_complete

With these changes the proper session token should be generated post login mutations from WPGraphQL JWT Authentication and WPGraphQL Headless Login, resolving the following issues.

Resolves #684
Resolves #682
Resolves #817

Does this close any currently open issues?

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

  • WooGraphQL Version:
  • WPGraphQL Version:
  • WordPress Version:
  • WooCommerce Version:

@kidunot89 kidunot89 added the bugfix Implements bugfix label Dec 27, 2023
@kidunot89 kidunot89 merged commit 6f80c4c into wp-graphql:develop Dec 27, 2023
14 checks passed
@kidunot89 kidunot89 deleted the fix/session-transaction-pop-fix branch December 27, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Implements bugfix
Projects
None yet
1 participant