feat: replace Appsero Updater.php with blank class to pass .org req's #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in the Appsero dependency - add build/Updater.php class to be used to copy and replace the Appsero Updater.php class with a blank class
josephfusco
approved these changes
Nov 27, 2023
… it happens every time composer install is run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
WordPress.org isn't allowing plugins that include the Appsero Client SDK to be approved for hosting on WordPress.org due to code in the Updater.php class. (see: Appsero/client#34)
This PR gets around that by replacing the Updater.php file with a blank Updater.php class during the plugin-build step
Does this close any currently open issues?
closes #129
Any other comments?
Ideally this is a temporary workaround as the Appsero team is working with WordPress.org on a more permanent solution