fix: performance issues for mapping field groups to the Schema

[jasonbahl]

What does this implement/fix? Explain your changes.

This addresses some performance issues related to mapping the ACF Field Groups to the Schema.

Currently there's logic in place that tries to determine what GraphQL Types in the schema should have a field to access the ACF Field Group from by parsing the field group's "location rules".

This logic is expensive and slow and already runs in the ACF Admin UI when creating/updating field groups, storing the types as the graphql_types field on the ACF Field Group.

Instead of running the location mapping at Schema Generation, we should rely on the field groups already defining a "graphql_types" field.

Plugin Build

Here's a built version of the plugin with these changes: wpgraphql-acf.zip

Does this close any currently open issues?

no (issue discussed in Slack)

Any relevant logs, error output, GraphiQL screenshots, etc?

I used an acf-json directory provided by a user. The config generated 234 Object Types implementing the AcfFieldGroup Interface.

Before

Trying to load the GraphQL Schema would take, well, a REALLY long time.

And executing a simple query such as:

{
  posts {
    nodes {
      id
      title
    }
  }
}

would also take a LONG time:

😱 😱 😱

AFTER

Now the Schema, with all 234 AcfFieldGroup Types, loads MUCH faster:

And the simple posts query also loads MUCH faster:

Any other comments?

This MIGHT be a breaking change for some users that don't have graphql_types defined on their ACF Field Groups.

Need to investigate this a bit more.

For users that have graphql_types defined on their ACF Field Groups this will work already.

[josephfusco]

LGTM! I was able to see a significant performance improvement applying these changes. Much better than before!