fix: errors when querying fields of the acfe_date_range_picker field type
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ults of resolve_field - update test suites - Add test for querying the daterangepicker
Pull Request Test Coverage Report for Build 2120cb25c7e08bdde8c612ee7fc40ee3bdc98c23-PR-166Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug where querying fields of the
acfe_date_range_pickerfield type would return the following error when queried:"DateTime::createFromFormat(): Argument #2 ($datetime) must be of type string, array given"
Does this close any currently open issues?
closes #163
Any other comments?
When querying a field of the
acfe_date_range_pickertype:BEFORE
PHP Errors were being thrown:
AFTER
No more errors: