Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass at creating a more extensible plugin #10

Merged
merged 14 commits into from
Feb 23, 2024
Merged

First pass at creating a more extensible plugin #10

merged 14 commits into from
Feb 23, 2024

Conversation

josephfusco
Copy link
Member

@josephfusco josephfusco commented Jan 22, 2024 •
edited

These changes setup the plugin to be extensible via WordPress' hook system using actions and filters (PHP + JS)

Initial ported hooks included with these changes:

@josephfusco
Add hooks dependency
48b0ea9 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Initialize hook system
9379e7d 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Merge branch 'main' into issue-4-hooks
3f22fe8
@josephfusco josephfusco linked an issue Feb 19, 2024 that may be closed by this pull request
Migrate WordPress Actions / Filters ☕️ #4
Closed
20 tasks
@josephfusco
Allow user to hook into graphiql enqueues
b32b033 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Add wpgraphqlide_enqueue_script
f1d918b 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Add wpgraphqlide_external_fragments
de89749 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Refactor plugin header retrieval
4e6de1f 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Add mount and destroy hooks
42cd1cb 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco josephfusco linked an issue Feb 22, 2024 that may be closed by this pull request
port graphiql_rendered from core plugin #25
Closed
3 tasks
@josephfusco
Inline docs to capture ported & new hooks
095ce6f 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Improve readability
1802719 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Improve readability
a38f31d 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco josephfusco changed the title Implement @wordpress/hooks First pass at creating a more extensible plugin Feb 22, 2024
@josephfusco josephfusco marked this pull request as ready for review February 22, 2024 21:16
@josephfusco
Temp improve maintainability
c069535 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
link to existing docs
d33461d 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco josephfusco self-assigned this Feb 23, 2024
@josephfusco josephfusco added the feature porting Porting features from the core WPGraphQL plugin label Feb 23, 2024
@josephfusco
Indicate new hook
a0e836f 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco josephfusco merged commit 7111f06 into main Feb 23, 2024
This was linked to issues Feb 23, 2024
port enqueue_graphiql_extension from core plugin #22
Closed
port graphiql_app_context from core plugin #38
Closed
port graphiql_external_fragments from core plugin #23
Closed
@jasonbahl jasonbahl deleted the issue-4-hooks branch May 17, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonbahl jasonbahl Awaiting requested review from jasonbahl

Assignees

@josephfusco josephfusco

Labels
feature porting Porting features from the core WPGraphQL plugin
Projects
None yet
Milestone
No milestone
1 participant
@josephfusco