Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffold playwright tests #15

Merged
merged 31 commits into from
Feb 26, 2024
Merged

Scaffold playwright tests #15

merged 31 commits into from
Feb 26, 2024

Conversation

josephfusco
Copy link
Member

@josephfusco josephfusco commented Feb 7, 2024 •
edited

These changes scaffold out End-to-end tests as well as unit tests.

@josephfusco
Scaffold playwright tests
f07ca7e 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Add wp-env dep
5ded68f 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Configure WP with required plugins
dabff9a 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Configured and passing tests
222e3f8 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
rename file
6e6edb9 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Add helpers
0c79e87 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Use test script instead of redefining commands
cd0eae7 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Test
86b9022 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
scaffold unit tests
4b59541 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Clean up workflow files
0b82c40 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
use v4 actions and cleanup
bf21628 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Passing tests
0b1c409 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco josephfusco linked an issue Feb 14, 2024 that may be closed by this pull request
Create test environment for GraphiQL 3 work #8
Closed
3 tasks
@josephfusco
Use local wp-env
c9eb368 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
use ci
99596cb 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Install required browsers
92d1962 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Add browser definitions back
33f8ca6 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco josephfusco marked this pull request as ready for review February 14, 2024 22:18
@josephfusco
Add new line at EOF
e601d62 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
View more things
595f1d8 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Correct test name
c712a6d 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Refactor E2E
37048cc 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@jasonbahl jasonbahl mentioned this pull request Feb 15, 2024
Closed
3 tasks
@josephfusco
passing
e0fb9a1 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Update env command
b4f2e7c 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
utilize arguments for less abstraction
d3ecbae 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Fix wp-env command in playwright callback
aeb9eb3 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
chore: update deps
ebb2acc 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Use WP tests
9f4cee6 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@josephfusco
Stop process once complete
aa9d9d5 
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
@jasonbahl
Copy link
Collaborator

jasonbahl commented Feb 19, 2024 •
edited

tests currently fail. re: WordPress/gutenberg#59183

looks like it's close to a resolution here: WordPress/gutenberg#59184

@josephfusco josephfusco self-assigned this Feb 23, 2024
@jasonbahl
Copy link
Collaborator

@josephfusco I pushed up a few commits that accomplish the following:

  • update docker-compose to get us passed the issue mentioned above:
  • added a 2nd test. Was failing until:
    • updated the loginToWordPressAdmin to wait for the page to finish loading before carrying on to the next action

Now we have the e2e tests passing with multiple tests executing.

Merging this and will continue to work on migrating other existing tests from the old GraphiQL

@jasonbahl jasonbahl merged commit 264659f into main Feb 26, 2024
3 checks passed
@jasonbahl jasonbahl deleted the setup-tests branch May 17, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@josephfusco josephfusco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create test environment for GraphiQL 3 work
2 participants
@josephfusco @jasonbahl