Consistent admin bar pattern #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
Signed-off-by: Joe Fusco <joe.fusco@wpengine.com>
jasonbahl
reviewed
Mar 7, 2024
| @@ -55,7 +55,7 @@ | |||
| <rule ref="WordPress.WP.I18n"> | |||
| <properties> | |||
| <property name="text_domain" type="array"> | |||
| <element value="wp-graphql" /> | |||
| <element value="wpgraphql-ide" /> | |||
jasonbahl
approved these changes
Mar 7, 2024
| @@ -3,7 +3,7 @@ import { Drawer as VaulDrawer } from 'vaul'; | |||
| import { useDispatch, useSelect } from '@wordpress/data'; | |||
|
|
|||
| export function EditorDrawer( { children } ) { | |||
| const buttonLabel = 'GraphQL IDE'; | |||
| const buttonLabel = '🚀'; | |||
There was a problem hiding this comment.
I'm cool with this as a short-term solution, but I anticipate re-visiting this at some point as I don't think the 🚀 really conveys to anyone other than you an I what this button really is meant for 🤔
But, at the moment I don't have another suggestion. Just thinking we might revisit this at some point. 🤷🏻♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes help to align the UX with what is currently expected, moving the current drawer button to be a 🚀 (for now)