-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent WP Rocket cache from being cleared multiple times #1558
Comments
I have another case here: https://secure.helpscout.net/conversation/801818620/100294?folderId=2683093 Flywheel is throwing the blame at us, their support team is giving this kind of answers:
|
This one sounds similar too, although I'm not seeing an obvious page builder listed: |
I am seeing that in general
This is what I logged:
|
https://secure.helpscout.net/conversation/813711318/102036/ |
Gutenberge always performs 2 calls to For the other page builders, we should be able to limit it to 1 time. |
When a post is being saved using Elementor or Divi Builder (haven't checked other page builders), the 'clean_post_cache' hook is triggered 3 times.
WP Rocket is running the partial cache purging with the array full of posts' related URLs 3 times while saving a single post in this situation.
When external software is being involved in the cache clearing process, there is a possibility that saving post will take much time.
Example:
Varnish cache clearing on Flywheel takes around 0.5-0.7 seconds for each request, which makes saving a post with the above page builders to take approximately 25 seconds (it depends on the number of related posts in the array)
I'm not sure if 3 'clean_post_cache' calls are necessary, on our end we can make sure that WP Rocket's cache is being cleared only after first one:
https://wp-media.slack.com/archives/C43T1AYMQ/p1551450912003800?thread_ts=1551362494.005200&cid=C43T1AYMQ
Related tickets:
https://secure.helpscout.net/conversation/764336044/94386?folderId=2415573
https://secure.helpscout.net/conversation/786974195/98071?folderId=2415573
The text was updated successfully, but these errors were encountered: