Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscriber for Upgrade/Renew/Promo events #3154

Closed
Tabrisrp opened this issue Sep 25, 2020 · 0 comments · Fixed by #3190
Closed

Subscriber for Upgrade/Renew/Promo events #3154

Tabrisrp opened this issue Sep 25, 2020 · 0 comments · Fixed by #3190
Assignees
@Tabrisrp
Labels
effort: [XS] < 1 day of estimated development time Module: dashboard type: sub-task Indicates the issue is a sub-task linked to an epics card

Comments

@Tabrisrp
Copy link
Contributor

Tabrisrp commented Sep 25, 2020 •
edited

Sub-task for epics #3067 #3068 #3069

The subscriber will manage the callbacks for the upgrade/renew/promo events on the appropriate hooks

Architecture

  • Class will be in inc/Engine/License, namespace WP_Rocket\Engine\License
  • name is Subscriber
  • Injection of the Upgrade, Renew and Promotions instances

Hooks & callbacks

  • rocket_after_license_info hook, callback Upgrade::display_license_section()
  • rocket_settings_page_footer hook, callback Upgrade::insert_upgrade_popin()

Loading

  • Add the subscriber license_subscriber to the Plugin::init_admin_subscribers() method

Tests

Integration tests
@Tabrisrp Tabrisrp added effort: [XS] < 1 day of estimated development time type: sub-task Indicates the issue is a sub-task linked to an epics card labels Sep 25, 2020
@Tabrisrp Tabrisrp mentioned this issue Sep 25, 2020
Closed
This was referenced Sep 28, 2020
Closed
Closed
@Tabrisrp Tabrisrp self-assigned this Oct 6, 2020
@Tabrisrp Tabrisrp mentioned this issue Oct 7, 2020
Merged
@Tabrisrp Tabrisrp linked a pull request Oct 7, 2020 that will close this issue
Closes #3154 Subscriber class for the upgrade events #3190
Merged
Tabrisrp added a commit that referenced this issue Oct 8, 2020
@Tabrisrp
Closes #3154 Subscriber class for the upgrade events (PR #3190)
a3c455d 
* add subscriber class
* add new filters
* instantiate the subscriber
* load the subscriber
* update test to clean transient
* add integration test for display_upgrade_section
* add integration tests for display_upgrade_popin
@Tabrisrp Tabrisrp closed this as completed Oct 8, 2020
Tabrisrp added a commit that referenced this issue Oct 9, 2020
@Tabrisrp
Closes #3067 Upgrade from the plugin (PR #3195)
55e722d 
* Closes #3149 PricingClient class to get data from pricing endpoint (PR #3174)
* Closes #3143 User Client class to manage data collection from user endpoint (PR #3176)
* Closes #3150 Pricing class to manage pricing data usage (PR #3179)
* User class to manage user data access (PR #3185)
* Closes #3151 Upgrade class to manage showing upgrade offers (PR #3186)
* Closes #3154 Subscriber class for the upgrade events (PR #3190)
* Closes #3153 JS code for the upgrade popin toggle (PR #3193)
* Closes #3152 CSS for the upgrade popin (PR #3194)
* show choices when license count is between single and plus
* add new tests for license between single and plus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tabrisrp Tabrisrp

Labels
effort: [XS] < 1 day of estimated development time Module: dashboard type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #3154 Subscriber class for the upgrade events wp-media/wp-rocket
1 participant
@Tabrisrp