Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto enable "Preload Links" and "Heartbeat Control" for new installs #3234

Closed
arunbasillal opened this issue Oct 22, 2020 · 1 comment · Fixed by #3288
Closed

Auto enable "Preload Links" and "Heartbeat Control" for new installs #3234

arunbasillal opened this issue Oct 22, 2020 · 1 comment · Fixed by #3288
Assignees
@Tabrisrp
Labels
effort: [XS] < 1 day of estimated development time module: heartbeat module: preload priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone
3.8

Comments

@arunbasillal
Copy link
Contributor

arunbasillal commented Oct 22, 2020 •
edited

Please enable these features by default for new WP Rocket installs. These two features are generally safe and have not created issues.

Why are we doing this?

To make WP Rocket easier to configure for our users. They will have two less decisions to make.

Notes

  • We are not removing the UI. We simply want these features to be enabled by default. i.e. add these in here.
  • The default values for Heartbeat activity stays the same as Reduce Activity. Simply enable the Control Heartbeat option by setting control_heartbeat to 1
@arunbasillal arunbasillal added module: heartbeat module: preload needs: grooming priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement labels Oct 22, 2020
@arunbasillal arunbasillal added this to the 3.8 milestone Oct 22, 2020
@Tabrisrp
Copy link
Contributor

Tabrisrp commented Nov 6, 2020

Scope a solution ✅

In inc/admin/upgrader.php, rocket_first_install(), change the value for control_heartbeat from 0 to 1.

In inc/Engine/Preload/Links/AdminSubscriber.php, add_option(), change the value from 0 to 1.

Estimate the effort ✅

Effort [XS]

@Tabrisrp Tabrisrp added effort: [XS] < 1 day of estimated development time and removed needs: grooming labels Nov 6, 2020
@Tabrisrp Tabrisrp self-assigned this Nov 10, 2020
@Tabrisrp Tabrisrp mentioned this issue Nov 10, 2020
Merged
@Tabrisrp Tabrisrp linked a pull request Nov 10, 2020 that will close this issue
Closes #3234 auto enable preload links & control heartbeat options for new install #3288
Merged
Tabrisrp added a commit that referenced this issue Nov 12, 2020
@Tabrisrp
Closes #3234 auto enable preload links & control heartbeat options fo…
ccf73af 
…r new install (PR #3288)

* set default value for control heartbeat to 1
* set default value for preload links to 1
* update tests fixtures
* update fixture for support data
@Tabrisrp Tabrisrp mentioned this issue Nov 26, 2020
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tabrisrp Tabrisrp

Labels
effort: [XS] < 1 day of estimated development time module: heartbeat module: preload priority: low Issues that can wait type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.8
2 participants
@Tabrisrp @arunbasillal