New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a notification when Mod Pagespeed is enabled and tell customers that it is likely to conflict with WP Rocket #3369
Comments
Related tickets - https://secure.helpscout.net/search/?query=tag%3Amod_pagespeed |
Do we know why we have the conflict? Maybe we can work towards making WP Rocket compatible with |
There is a lot of features duplication between WP Rocket and the pagespeed module. Working toward being compatible would be like working to be compatible with W3 Total Cache or Swift Performance. |
Thanks for the feedback Remy 👍 Makes sense. |
On a ticket I worked on, I had to exclude the following to prevent a The URL of the What do you think about at least excluding that pattern in the core? Related ticket: https://secure.helpscout.net/conversation/1335093437/210973?folderId=2135277 |
@vmanthos If we are going ahead with the notice suggesting to disable Mod Pagespeed, then is this still required? Or is this one of the most common issues where some users could still get by without disabling mod_pagespeed? |
My comment was out of context. I apologize.
In such a case, it won't be. 🙏 |
GroomingScope a solution ✅
Estimate the effort ✅[S] @wp-media/productrocket we need the message that will appear to the customer. |
@wp-media/productrocket @arunbasillal we have two questions please:-
Thanks. |
Is this possible? If |
@wp-media/productrocket so the message will be like that:
Please confirm. |
@arunbasillal @webtrainingwheels Is it the expected doc to link? |
@GeekPress @webtrainingwheels I think we could create a specific documentation for the same. Or maybe a separate section in the doc with an #anchor text. Please advise Lucy. |
Had a quick chat with Ahmed and he said that we are not reusing rocket_plugins_to_deactivate(), and instead we are doing a new notice. (For reference, I had asked if this was possible to re-use - #3369 (comment)) @webtrainingwheels In that case, isn't it better if we simply have a notice as below instead of - #3369 (comment)
|
@arunbasillal @GeekPress
We could make a dedicated doc but what message/info would we like to convey? 🤔 |
|
@wp-media/productrocket
also I need to validate another point here, check the following comment: #3390 (comment) |
@engahmeds3ed Here is the doc link: https://docs.wp-rocket.me/article/1376-mod-pagespeed |
@engahmeds3ed Can we make the notice dismissible instead or it popping up every day? If users do not see a conflict with WP Rocket and wants to keep mod_pagespeed, they can simply dismiss the notice and never see it again. I think that would be better. If the notice pops up every day, we are definitely going to have users asking for an option to disable it. |
@arunbasillal It's already like that so the clients can dismiss the message not to see it again. |
@engahmeds3ed To make sure I understand correctly:
In this case the notice is never displayed anymore, right? (sorry for double checking) |
@engahmeds3ed That looks neat to me 👍 |
Just stumbled across this message in WP Rocket, and after disabling mod_pagespeed on the server, our PageSpeed Insight results have regressed. I think this message should explicitly state which specific features are not compatible, so the user can decide if they would like them managed at the application or server level. Could some of these optimisations actually be better managed at the server level? |
I can't see which feature done by mod_pagespeed could be better than what another tool like WP Rocket does. |
@GeekPress Even so, the existing message is very vague (unexpected results!).
If this statement by @webtrainingwheels is correct, then many may find it easier to just disable critical CSS in WP Rocket, than perform server administration uninstalling mod_pagespeed. |
@twobyte Critical CSS is too much important to be disabled. Please correct, but mod_pagespeed doesn't do CPCSS as it should be done correctly. By the way, mod_pagespeed isn't maintained since 2015. We will never recommend using an abandoned tool. |
Is your feature request related to a problem? Please describe.
Add a notification when Mod Pagespeed is enabled and tell customers that it is likely to conflict with WP Rocket, and that they should turn it off on their server to avoid any issues.
Describe the solution you'd like
We can check if Mod Pagespeed is enabled, maybe using the response header they send, and show notification on WP Rocket dashboard.
Describe alternatives you've considered
N/A
Additional context
Mod Pagespeed adds the following headers:
The text was updated successfully, but these errors were encountered: