Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sidebar content #3913

Closed
GeekPress opened this issue May 14, 2021 · 1 comment · Fixed by #4026
Closed

Replace sidebar content #3913

GeekPress opened this issue May 14, 2021 · 1 comment · Fixed by #4026
Assignees
@iCaspar
Labels
effort: [XS] < 1 day of estimated development time Module: dashboard priority: high Issues which should be resolved as quickly as possible type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone
3.9.0.4

Comments

@GeekPress
Copy link
Contributor

GeekPress commented May 14, 2021 •
edited

Describe the solution you'd like
We would like to update the content of our sidebar.

Learn how to use best practices to correctly measure your site's performance.

This text will be replaced by

Learn about optimal WP Rocket settings for mobile.

CTA:

Why Google PageSpeed grade should not matter

This text will be replaced by

Test and Improve Google Core Web Vitals for WordPress.

CTA: https://wp-rocket.me/google-core-web-vitals-wordpress/
@GeekPress GeekPress added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement priority: high Issues which should be resolved as quickly as possible needs: grooming labels May 14, 2021
@Tabrisrp
Copy link
Contributor

Scope a solution ✅

In views/settings/partials/sidebar.php

Replace the texts and links by the new value we want to display. For the first CTA displayed in different languages, we need to add a check for the current user locale to determine which version to show.

Estimate the effort ✅

Effort [XS]

@Tabrisrp Tabrisrp added effort: [XS] < 1 day of estimated development time and removed needs: grooming labels May 19, 2021
@iCaspar iCaspar self-assigned this Jun 9, 2021
@iCaspar iCaspar mentioned this issue Jun 9, 2021
Merged
6 tasks
@Tabrisrp Tabrisrp modified the milestone: 3.9.0.2 Jun 10, 2021
@GeekPress GeekPress added this to the 3.9.0.3 milestone Jun 15, 2021
Tabrisrp pushed a commit that referenced this issue Jun 17, 2021
@iCaspar
Closes #3913 Change sidebar text and link w/check for locale (PR #4026)
ef3c6a2
@Tabrisrp Tabrisrp modified the milestones: 3.9.0.3, 3.9.0.4 Jun 18, 2021
@Tabrisrp Tabrisrp mentioned this issue Jun 23, 2021
Merged
engahmeds3ed added a commit that referenced this issue Jun 24, 2021
@engahmeds3ed
Merge pull request #4090 from wp-media/develop
d9df468 
- Enhancement: Update links on settings page sidebar (Replace sidebar content #3913)
- Enhancement: Disable delay JS by default for new installations (Don't activate Delay JS for new users by default + delay everything once it will be activated #4085)
- Bugfix: delete used-css folder on uninstall (Used CSS folder shall be deleted when deleting the plugin #3966)
- Bugfix: Add swap property to fonts in used CSS (RUCSS does not add the font-display="swap" property when Optimize CSS Delivery is not active #3993)
- Bugfix: Prevent used CSS generation from processing styles inside noscript elements (RUCSS problem with <noscript> tags #3957)
- Bugfix: Avoid used CSS generation from being stuck in some cases (Fix RUCSS ResourceFetcher fetch all page urls #3988)
- 3rd party compatibility: Exclude some JS of GTM4WP from delay JS (Add Delay JS exclusion related to Google Tag Manager for WordPress #4071)
- 3rd party compatibility: Avoid an error when using ShortPixel AI with Remove Unused CSS enabled (3.9 RUCSS - PHP Fatal error - too few arguments passed in rocket_css_content #3991)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iCaspar iCaspar

Labels
effort: [XS] < 1 day of estimated development time Module: dashboard priority: high Issues which should be resolved as quickly as possible type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.9.0.4
Development

Successfully merging a pull request may close this issue.

Closes #3913 Change sidebar text and link w/check for locale wp-media/wp-rocket
3 participants
@GeekPress @Tabrisrp @iCaspar