Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncode theme compatibility #4366

Closed
piotrbak opened this issue Sep 20, 2021 · 4 comments · Fixed by #4370
Closed

Uncode theme compatibility #4366

piotrbak opened this issue Sep 20, 2021 · 4 comments · Fixed by #4370
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: defer JS module: delay JS needs: r&d Needs research and development (R&D) before a solution can be proposed and scoped. priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement

Comments

@piotrbak
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In upcoming weeks Uncode is going to release an update. We'll need to add some new exclusions to be still fully compatible.

Describe the solution you'd like
We need to exclude the following files here:
/library/js/init.min.js
/library/js/ai-uncode.min.js

And one more file here:
/library/js/init.min.js

@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: defer JS module: delay JS labels Sep 20, 2021
@Tabrisrp Tabrisrp added this to the 3.10.1 milestone Oct 1, 2021
@Tabrisrp Tabrisrp mentioned this issue Oct 14, 2021
@NataliaDrause
Copy link
Contributor

@piotrbak
there are new errors that popped up with Uncode and our Combine JS.

When no exclusions are added and only Minify JS and Combine JS are enabled, we get these errors:
image
full-screen image: https://i.imgur.com/n5vsMyt.png

We automatically exclude some Uncode files here. It seems, some of these files require jQuery and hooks.min.js.

Adding the following exclusions for Combine JS resolves the errors:

/wp-includes/js/jquery/jquery.min.js
/wp-includes/js/dist/hooks.min.js

Interestingly, Defer JS doesn't require jQuery exclusions. No errors when Minify+Combine with exclusions above + Defer JS with no exclusions are enabled. jQuery is being deferred.

When Delay JS is enabled, it additionally requires jQuery exclusions:

/jquery/jquery.min.js
/jquery/jquery-migrate.min.js

Ticket: https://secure.helpscout.net/conversation/1781372866/324847/

@piotrbak piotrbak reopened this Feb 9, 2022
@piotrbak piotrbak removed this from the 3.10.1 milestone Feb 9, 2022
@piotrbak piotrbak added the priority: medium Issues which are important, but no one will go out of business. label Feb 9, 2022
@Mai-Saad
Copy link

Mai-Saad commented Feb 9, 2022

Couldn't reproduce it on the test site using 3.10.7 with the default setup (account not registered)
Note: Maybe the problem with certain setup or other plugin is used with default auto exclusion to jQuery (further investigation is needed)

@piotrbak
Copy link
Contributor Author

@NataliaDrause Do you happen to have a staging environment where we could see the problem?

@NataliaDrause
Copy link
Contributor

Yes, there is a staging site in the ticket: https://secure.helpscout.net/conversation/1781372866/324847/
Customer provided credentials and they are still working for me.

@piotrbak piotrbak added the needs: r&d Needs research and development (R&D) before a solution can be proposed and scoped. label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: defer JS module: delay JS needs: r&d Needs research and development (R&D) before a solution can be proposed and scoped. priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants