Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility issue - DJE with recommended Elementor exclusions duplicates element with the same ID #5282

Closed
4 tasks
juricazuanovic opened this issue Jul 26, 2022 · 2 comments · Fixed by #5876
Closed
4 tasks

Accessibility issue - DJE with recommended Elementor exclusions duplicates element with the same ID #5282

juricazuanovic opened this issue Jul 26, 2022 · 2 comments · Fixed by #5876
Assignees
@jeawhanlee
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: delay JS priority: medium Issues which are important, but no one will go out of business. severity: major Feature is not working as expected and no work around available type: bug Indicates an unexpected problem or unintended behavior
Milestone
3.13.3

Comments

@juricazuanovic
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version -3.11.4
  • Used the search feature to ensure that the bug hasn’t been reported before - yes

Describe the bug
When using Delay JavaScript execution with recommended Elementor exclusions, it causes the duplication of <span id="elementor-device-mode" class="elementor-screen-only"></span> element. Duplicate id values can degrade both functionality and accessibility. Most importantly, it creates an issue for sites that have to meet government issued Accessibility requirements and regulations.

To Reproduce
Steps to reproduce the behavior:

  1. With installed Elementor enable Delay JavaScript execution
  2. Add recommended Elementor exclusions
  3. Visit the site and check the code in DOM inspector
  4. See error

Expected behavior
Delay JavaScript execution shouldn't duplicate the element with the same ID and cause the issue with the Accessibility.

Screenshots
https://i.imgur.com/7M4b10l.png

Additional context
Ticket: https://secure.helpscout.net/conversation/1949143754/355955/
Slack: https://wp-media.slack.com/archives/C08N8J6VC/p1658495777408619

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem
  • Identify the root cause
  • Scope a solution
  • Estimate the effort
@piotrbak piotrbak added type: bug Indicates an unexpected problem or unintended behavior 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting priority: medium Issues which are important, but no one will go out of business. severity: major Feature is not working as expected and no work around available module: delay JS labels Aug 1, 2022
@piotrbak piotrbak added this to the 3.13.3 milestone Apr 12, 2023
@piotrbak
Copy link
Contributor

The solution is proposed in the linked issue from Delay JS Script repo

@jeawhanlee jeawhanlee added GROOMING IN PROGRESS Use this label when the issue is currently being groomed. and removed GROOMING IN PROGRESS Use this label when the issue is currently being groomed. labels Apr 17, 2023
@jeawhanlee jeawhanlee self-assigned this Apr 17, 2023
@jeawhanlee jeawhanlee mentioned this issue Apr 18, 2023
Merged
4 tasks
@Mai-Saad
Copy link

Note for testing: reproducible on https://rocketlabsqa.ovh/ using 3.13.1, when enable DJS with/without Elementor exclusions

@piotrbak piotrbak removed this from the 3.13.3 milestone Apr 23, 2023
@piotrbak piotrbak added this to the 3.13.3 milestone May 10, 2023
@engahmeds3ed engahmeds3ed mentioned this issue May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeawhanlee jeawhanlee

Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: delay JS priority: medium Issues which are important, but no one will go out of business. severity: major Feature is not working as expected and no work around available type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.13.3
Development

Successfully merging a pull request may close this issue.

Closes #5282: DJE duplicates ID with elementor recommended exclusions wp-media/wp-rocket
4 participants
@juricazuanovic @piotrbak @jeawhanlee @Mai-Saad