Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #5282: DJE duplicates ID with elementor recommended exclusions #5876

Merged
merged 9 commits into from
May 10, 2023
Merged

Closes #5282: DJE duplicates ID with elementor recommended exclusions #5876

merged 9 commits into from
May 10, 2023

Conversation

jeawhanlee
Copy link
Contributor

Description

Fixes duplicated element ID when DJE elementor recommended exclusion is used.

Fixes #5282

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@jeawhanlee jeawhanlee added type: bug Indicates an unexpected problem or unintended behavior 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: delay JS labels Apr 18, 2023
@jeawhanlee jeawhanlee added this to the 3.13.3 milestone Apr 18, 2023
@jeawhanlee jeawhanlee self-assigned this Apr 18, 2023
@jeawhanlee jeawhanlee marked this pull request as ready for review April 18, 2023 08:16
@jeawhanlee jeawhanlee requested a review from a team April 18, 2023 08:16
@piotrbak piotrbak removed this from the 3.13.3 milestone Apr 23, 2023
@vmanthos vmanthos self-requested a review April 24, 2023 10:54
@piotrbak
Copy link
Contributor

The issue is still there, asked for help here:
https://github.com/wp-media/delay-javascript-loading/issues/39#issuecomment-1520144005

@piotrbak
Copy link
Contributor

@jeawhanlee There's an update from Gael about this one.

vmanthos
vmanthos approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@vmanthos vmanthos left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected! 👍

TestRail report
testrail-report-480.pdf

@vmanthos vmanthos added this pull request to the merge queue May 10, 2023
Merged via the queue into develop with commit fb51371 May 10, 2023
7 checks passed
@vmanthos vmanthos deleted the fix/5282-DJE-duplicates-id-with-recommended-exclusions branch May 10, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmanthos vmanthos vmanthos approved these changes

@mostafa-hisham mostafa-hisham mostafa-hisham approved these changes

@Tabrisrp Tabrisrp Awaiting requested review from Tabrisrp

Assignees

@jeawhanlee jeawhanlee

Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: delay JS type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility issue - DJE with recommended Elementor exclusions duplicates element with the same ID
5 participants
@jeawhanlee @piotrbak @vmanthos @Tabrisrp @mostafa-hisham