Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update texts and banners for users with an expired license #5397

Closed
Agathemed opened this issue Sep 6, 2022 · 4 comments · Fixed by #5419
Closed

Update texts and banners for users with an expired license #5397

Agathemed opened this issue Sep 6, 2022 · 4 comments · Fixed by #5419
Assignees
@Tabrisrp
Labels
effort: [S] 1-2 days of estimated development time module: user interface priority: high Issues which should be resolved as quickly as possible type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone
3.12.2

Comments

@Agathemed
Copy link

The messages for users with an expired license need to be updated:

  • to inform users about the optimize CSS features that will/have disappear/ed
  • to display the correct renewal price

Conditions and messages are available here.
@piotrbak piotrbak added priority: high Issues which should be resolved as quickly as possible needs: grooming module: user interface type: enhancement Improvements that slightly enhance existing functionality and are fast to implement labels Sep 6, 2022
@CrochetFeve0251
Copy link
Contributor

CrochetFeve0251 commented Sep 7, 2022 •
edited

@Agathemed from what I saw in the code we need to add new cases for the licence, am I right?

Just want to confirm before grooming.

@Agathemed
Copy link
Author

I believe the only case that is not in place yet is the "not grand-fathered user" scenario.

@CrochetFeve0251 CrochetFeve0251 added GROOMING IN PROGRESS Use this label when the issue is currently being groomed. needs: grooming and removed needs: grooming GROOMING IN PROGRESS Use this label when the issue is currently being groomed. labels Sep 7, 2022
@CrochetFeve0251
Copy link
Contributor

@piotrbak look like the API doesn't provides us the information if an user is grand-fathered.

@piotrbak piotrbak added this to the 3.12.2 milestone Sep 11, 2022
@Tabrisrp
Copy link
Contributor

Scope a solution ✅

We need to update all the banners to update the part related to the price + discount that is going to be offered.

In Engine\License\Renewal:

  • Update display_renewal_soon_banner() method to check for grandfathered and change the message returned
  • Update display_renewal_expired_banner() method to check for grandfathered and change the message returned
  • Update the renewal views to display the new message from the variable
  • Update the related tests

Estimate the effort ✅

Effort [S]

@Tabrisrp Tabrisrp added effort: [S] 1-2 days of estimated development time and removed needs: grooming labels Sep 13, 2022
@Tabrisrp Tabrisrp self-assigned this Sep 13, 2022
@Tabrisrp Tabrisrp mentioned this issue Sep 13, 2022
Merged
7 tasks
vmanthos added a commit that referenced this issue Oct 7, 2022
@vmanthos
Merge pull request #5419 from wp-media/enhancement/5397-license-banners
0cd5269 
Closes #5397 Update license renewal banners content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tabrisrp Tabrisrp

Labels
effort: [S] 1-2 days of estimated development time module: user interface priority: high Issues which should be resolved as quickly as possible type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.12.2
Development

Successfully merging a pull request may close this issue.

Closes #5397 Update license renewal banners content wp-media/wp-rocket
4 participants
@Tabrisrp @CrochetFeve0251 @piotrbak @Agathemed