Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Used CSS table isnot cleared when changing permalinks #5506

Closed
4 tasks
Mai-Saad opened this issue Oct 14, 2022 · 0 comments · Fixed by #5623
Closed
4 tasks

Used CSS table isnot cleared when changing permalinks #5506

Mai-Saad opened this issue Oct 14, 2022 · 0 comments · Fixed by #5623
Assignees
@vmanthos @Tabrisrp
Labels
effort: [XS] < 1 day of estimated development time module: remove unused css priority: low Issues that can wait severity: moderate Feature isn't working as expected but has work around to get same value type: bug Indicates an unexpected problem or unintended behavior
Milestone
3.12.5

Comments

@Mai-Saad
Copy link

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version => 3.12.1.1
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
Changing permalinks is not clearing used CSS table which results in many URLs for pages not found

To Reproduce
Steps to reproduce the behavior:

  1. With permalinks /post/ and while preload is enabled
  2. Enable RUCSS => wait till some pages are completed
  3. Change permalinks to Numeric

Expected behavior
Clearing Used CSS table

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem
  • Identify the root cause
  • Scope a solution
  • Estimate the effort
@Mai-Saad Mai-Saad added type: bug Indicates an unexpected problem or unintended behavior priority: low Issues that can wait severity: moderate Feature isn't working as expected but has work around to get same value module: remove unused css labels Oct 14, 2022
@GeekPress GeekPress added this to the 3.12.4 milestone Oct 26, 2022
@Tabrisrp Tabrisrp self-assigned this Dec 13, 2022
@Tabrisrp Tabrisrp added effort: [XS] < 1 day of estimated development time and removed needs: grooming labels Dec 13, 2022
@Tabrisrp Tabrisrp mentioned this issue Dec 13, 2022
Merged
5 tasks
@vmanthos vmanthos self-assigned this Dec 14, 2022
Mai-Saad pushed a commit that referenced this issue Dec 15, 2022
@Tabrisrp
Closes #5506 Clean used CSS on permalink structure change (#5623)
4343ee1 
* clean used CSS on permalink structure change
* remove callback for permalink_structure_changed
* use public method
@piotrbak piotrbak modified the milestones: 3.12.4, 3.12.5 Dec 29, 2022
@Tabrisrp Tabrisrp mentioned this issue Jan 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmanthos vmanthos

@Tabrisrp Tabrisrp

Labels
effort: [XS] < 1 day of estimated development time module: remove unused css priority: low Issues that can wait severity: moderate Feature isn't working as expected but has work around to get same value type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.12.5
Development

Successfully merging a pull request may close this issue.

Closes #5506 Clean used CSS on permalink structure change wp-media/wp-rocket
5 participants
@vmanthos @GeekPress @Tabrisrp @piotrbak @Mai-Saad