Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Minify dependency with latest changes #5617

Closed
piotrbak opened this issue Dec 9, 2022 · 1 comment · Fixed by #5627
Closed

Update Minify dependency with latest changes #5617

piotrbak opened this issue Dec 9, 2022 · 1 comment · Fixed by #5627
Assignees
@jeawhanlee
Labels
effort: [XS] < 1 day of estimated development time module: minify CSS module: minify JS priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone
3.12.6

Comments

@piotrbak
Copy link
Contributor

piotrbak commented Dec 9, 2022

Is your feature request related to a problem? Please describe.
We should update the minification library.

It'll fix the following issues:

Additional context
We need to make sure we won't introduce regression described here:
@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement priority: medium Issues which are important, but no one will go out of business. needs: grooming module: minify CSS module: minify JS labels Dec 9, 2022
@piotrbak piotrbak added this to the 3.12.5 milestone Dec 9, 2022
@jeawhanlee jeawhanlee self-assigned this Dec 14, 2022
@jeawhanlee
Copy link
Contributor

jeawhanlee commented Dec 14, 2022 •
edited
Loading

We can simply update the pattern in

wp-rocket/inc/Dependencies/Minify/CSS.php

Line 743 in 1f30942

'/(?<=^|[;}])\s*(--[^:;{}"\'\s]+)\s*:([^;{}]+)/m',
to /(?<=^|[;}{])\s*(--[^:;{}"\'\s]+)\s*:([^;{}]+)/m which is the current change that fixes this issue.
I don't think this little change should introduce any regression.

@jeawhanlee jeawhanlee added effort: [XS] < 1 day of estimated development time and removed needs: grooming labels Dec 14, 2022
@jeawhanlee jeawhanlee mentioned this issue Dec 14, 2022
Merged
4 tasks
@piotrbak piotrbak modified the milestones: 3.12.5, 3.12.6 Dec 29, 2022
@piotrbak piotrbak mentioned this issue Jan 15, 2023
Open
4 tasks
This was referenced Feb 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeawhanlee jeawhanlee

Labels
effort: [XS] < 1 day of estimated development time module: minify CSS module: minify JS priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.12.6
Development

Successfully merging a pull request may close this issue.

Closes #5617 Update Minify dependency with latest changes wp-media/wp-rocket
3 participants
@piotrbak @jeawhanlee and others