PHP Deprecated: notices with PHP 8.2.3

[Mai-Saad]

Before submitting an issue please check that you’ve completed the following steps:

• Made sure you’re on the latest version => 3.12.6.1
• Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
PHP Deprecated notice (count 150+) exists in debug.log while site is using PHP 8.2.3
[08-Mar-2023 14:51:05 UTC] PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/inc/Engine/Optimization/DelayJS/HTML.php on line 253
[08-Mar-2023 14:51:09 UTC] PHP Deprecated: Creation of dynamic property WP_Rocket\Engine\Preload\Database\Rows\CacheRow::$id is deprecated in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/inc/Dependencies/Database/Base.php on line 266
To Reproduce
Steps to reproduce the behavior:

1. Website using PHP 8.2.3
2. Install and activate WPR
3. check debug.log

Expected behavior
no deprecated notice in debug.log

Additional context
Add any other context about the problem here.

• This doesn't exist with PHP 8.1.14

Backlog Grooming (for WP Media dev team use only)

• Reproduce the problem
• Identify the root cause
• Scope a solution
• Estimate the effort

[piotrbak]

@Mai-Saad Did you enable all WP Rocket's options + performed some operations like clearing the cache, etc.?

It would be good to resolve as many deprecations as possible here.

[Mai-Saad]

@piotrbak After enable all options and play around with admin bar, the deprecation logs will be 7K + (mostly for preload)

[jeawhanlee]

Opened a PR at berlinDB that should fix this.

[vmanthos]

I got the same on a Multisite (8.2.1):

[27-Mar-2023 10:07:52 UTC] PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /shared/httpd/multisite/htdocs/wp-content/plugins/wp-rocket/inc/Engine/Optimization/DelayJS/HTML.php on line 254
[27-Mar-2023 10:07:52 UTC] PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /shared/httpd/multisite/htdocs/wp-content/plugins/wp-rocket/inc/Engine/Optimization/DelayJS/HTML.php on line 264
[27-Mar-2023 10:07:52 UTC] PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /shared/httpd/multisite/htdocs/wp-content/plugins/wp-rocket/inc/Engine/Optimization/DelayJS/HTML.php on line 273

There are more occurrences of the ${var} pattern in wp-rocket/inc/Engine/Optimization/DelayJS/HTML.php.

[piotrbak]

@jeawhanlee In this PR let's update the berlinDB version.

[piotrbak]

@vmanthos Moved your comment to the new issue:
#5862

[piotrbak]

@jeawhanlee How it's going with this one?

[codemonkeynorth]

adding in case these have been missed

(Current version of WP Rocket: 3.8.2)

thanks
J

---

Deprecated: Creation of dynamic property WP_Rocket\Engine\Preload\SitemapPreloadSubscriber::$options is deprecated in /wp-content/plugins/wp-rocket/inc/Engine/Preload/SitemapPreloadSubscriber.php on line 26

Deprecated: Creation of dynamic property WP_Rocket\Engine\Preload\SitemapPreloadSubscriber::$sitemap_preload is deprecated in /wp-content/plugins/wp-rocket/inc/Engine/Preload/SitemapPreloadSubscriber.php on line 27

Deprecated: Automatic conversion of false to array is deprecated in /wp-content/plugins/wp-rocket/inc/3rd-party/plugins/seo/yoast-seo.php on line 10