Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP deprecation errors on 8.2.1 DelayJS/html.php file. #5862

Closed
4 tasks
piotrbak opened this issue Apr 10, 2023 · 2 comments · Fixed by #5864
Closed
4 tasks

PHP deprecation errors on 8.2.1 DelayJS/html.php file. #5862

piotrbak opened this issue Apr 10, 2023 · 2 comments · Fixed by #5864
Assignees
Labels
module: delay JS priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone

Comments

@piotrbak
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
We're getting the following warnings in specific conditions:

[27-Mar-2023 10:07:52 UTC] PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /shared/httpd/multisite/htdocs/wp-content/plugins/wp-rocket/inc/Engine/Optimization/DelayJS/HTML.php on line 254
[27-Mar-2023 10:07:52 UTC] PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /shared/httpd/multisite/htdocs/wp-content/plugins/wp-rocket/inc/Engine/Optimization/DelayJS/HTML.php on line 264
[27-Mar-2023 10:07:52 UTC] PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /shared/httpd/multisite/htdocs/wp-content/plugins/wp-rocket/inc/Engine/Optimization/DelayJS/HTML.php on line 273

Expected behavior
No warnings

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem
  • Identify the root cause
  • Scope a solution
  • Estimate the effort
@piotrbak piotrbak added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement priority: medium Issues which are important, but no one will go out of business. module: delay JS labels Apr 10, 2023
@piotrbak piotrbak added this to the 3.13.2 milestone Apr 10, 2023
@piotrbak piotrbak changed the title PHP depracation errors on 8.2.1 DelayJS/html.php file. PHP deprecation errors on 8.2.1 DelayJS/html.php file. Apr 10, 2023
@piotrbak piotrbak linked a pull request Apr 10, 2023 that will close this issue
4 tasks
@piotrbak piotrbak removed a link to a pull request Apr 10, 2023
4 tasks
@vmanthos
Copy link
Contributor

There is a deprecation notice when Minify JavaScript Files is enabled:

PHP Deprecated: Use of "parent" in callables is deprecated in /shared/httpd/wprocketest/htdocs/wp-content/plugins/wp-rocket/inc/Dependencies/Minify/JS.php on line 127

@piotrbak Do you want a separate issue about this?

@piotrbak
Copy link
Contributor Author

@vmanthos we can resolve it here 👍

This was referenced May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: delay JS priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants