New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The mobile version of the homepage isn't preloaded in priority when separate cache for mobile devices is enabled #6040
Comments
Acceptance Criteria: 1. When separate cache for mobiles is enabled when activating the plugin:
2. When separate cache for mobiles is enabled when clearing the Used CSS:
3. When separate cache for mobiles is disabled when activating the plugin:
4. When separate cache for mobiles is disabled when clearing the Used CSS:
|
@vmanthos When clearing the used CSS, did you do it from the admin side or from the front side via the admin bar? The homepage preload is hooked on the used CSS clear, but only on the admin side. |
@Tabrisrp I cleared it using the admin bar menu item while in WP Rocket's dashboard. |
Reproduce the issue ✅Reproduced Identify the root cause ✅There is 2 different parts in this issue, the activation one and the RUCSS clean one. For the activation, we do a request to the homepage when activating, but we do not do the request for mobile. For the RUCSS clean one, I noticed that we do have a method hooked on the related action, but right after in the There is only a cache file for the desktop version because there is a manual call to the homepage in the method after. Scope a solution ✅in
in
in
Estimate the effort ✅Effort [S] |
@vmanthos, @Mai-Saad, @piotrbak: following Tabrisrp's investigation, he pointed out 2 issues. Would it be interesting to rework the acceptance criteria here? I might not understand everything, but it seems the AC cover the activation part (checking we send the right requests on activation), but not the RUCSS side-effect. |
@MathieuLamiot @vmanthos Updated the AC |
Before submitting an issue please check that you’ve completed the following steps:
3.14.1
Describe the bug
On certain occasions, e.g. when activating WP Rocket, or when clearing the used CSS, we are preloading the homepage in priority:
wp-rocket/inc/Engine/Activation/Activation.php
Lines 94 to 102 in 4c697c3
If the "Separate cached files for mobile devices" is enabled we aren't preloading that version. Eventually, the mobile-specific file will be preloaded but that can take a while.
To Reproduce
Steps to reproduce the behavior:
/cache/wp-rocket/
folder.Expected behavior
Preload the mobile-specific cached file of the homepage whenever we do that for the desktop version.
Screenshots
N/A
Additional context
The
user-agent
we use isWP Rocket/Homepage Preload
. We need to add a request using a mobileuser-agent
wherever that one is used.Backlog Grooming (for WP Media dev team use only)
The text was updated successfully, but these errors were encountered: