Lazyload for CSS background images - do not modify excluded images markup #6146
Labels
effort: [S]
1-2 days of estimated development time
module: lazyload background css images
priority: medium
Issues which are important, but no one will go out of business.
type: enhancement
Improvements that slightly enhance existing functionality and are fast to implement
Milestone
Is your feature request related to a problem? Please describe.
Currently, when an image is excluded from the feature, the
data-rocket-lazy-bg="loaded"
is still added to it, and thebackground-image
value is still switched to a variable, like if the feature was applied to it, although the excluded image is indeed loaded without lazyload.Describe the solution you'd like
Excluded images could have the attribute not added and the background-image value not changed; i.e. the excluded images markup could not be modified to prevent confusion.
Describe alternatives you've considered
If applying all these changes is too complex, we should document this properly informing the customers that all this will still be applied, but that they can check in the network tab that excluded images are indeed excluded.
Additional context
Screenshots:
https://share.getcloudapp.com/RBuzexNE
https://share.getcloudapp.com/RBuzexrl
The text was updated successfully, but these errors were encountered: