We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Before submitting an issue please check that you’ve completed the following steps:
Describe the bug
We won't be adding the fetchpriority property if one already exists:
fetchpriority
wp-rocket/inc/Engine/Media/AboveTheFold/Frontend/Controller.php
Line 135 in 134ac6a
However, if it's added with spaces before of after the = sign like so:
=
<img src="https://example.com/dummy.png" fetchpriority = "high">
we will not detect it and add our own on top of it.
See the current RegEx in action: https://regex101.com/r/cqHgtE/1
To Reproduce Steps to reproduce the behavior:
Expected behavior
The fetchpriority property should be correctly detected even if there are spaces before/after the = sign.
Screenshots
N/A
Additional context
Acceptance Criteria (for WP Media team use only) Clear instructions for developers, to be added before the grooming
The text was updated successfully, but these errors were encountered:
Fixes #6325 Detect existing fetchpriority attribute when spaces aroun…
5bc4249
…d equal sign (#6335) Co-authored-by: Michael Lee <michaelleemichaellee408@gmail.com>
Tabrisrp
Successfully merging a pull request may close this issue.
Before submitting an issue please check that you’ve completed the following steps:
Describe the bug
We won't be adding the
fetchpriority
property if one already exists:wp-rocket/inc/Engine/Media/AboveTheFold/Frontend/Controller.php
Line 135 in 134ac6a
However, if it's added with spaces before of after the
=
sign like so:we will not detect it and add our own on top of it.
See the current RegEx in action: https://regex101.com/r/cqHgtE/1
To Reproduce
Steps to reproduce the behavior:
fetchpriority
property will be there.Expected behavior
The
fetchpriority
property should be correctly detected even if there are spaces before/after the=
sign.Screenshots
N/A
Additional context
N/A
Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming
The text was updated successfully, but these errors were encountered: