Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LL BGCSS markup problem with 3.15.7 #6360

Closed
piotrbak opened this issue Jan 3, 2024 · 0 comments · Fixed by #6362
Closed

LL BGCSS markup problem with 3.15.7 #6360

piotrbak opened this issue Jan 3, 2024 · 0 comments · Fixed by #6362
Assignees
@Miraeld
Labels
module: lazyload background css images priority: high Issues which should be resolved as quickly as possible severity: minor Defect that does not affect functionality type: bug Indicates an unexpected problem or unintended behavior
Milestone
3.15.7

Comments

@piotrbak
Copy link
Contributor

piotrbak commented Jan 3, 2024 •
edited

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
In 3.15.7 we're changing a bit the way of lazyloading BG images.

However, in #6269 the <style> tags are added inside the <body> and <div class="wpr-lazyload-bg">:
https://wp-media.slack.com/files/U01FX2Z4GET/F06CCV8TRGU/3.15.7.png

It's causing HTML validation errors.

Expected behavior
We should add new <style> tags inside the <head>, just after the <style id="wpr-lazyload-bg"></style>, to make it easier for Support Team to find the tags.

Additional context
Full conversation: (https://wp-media.slack.com/archives/CUKB44GNN/p1704297291848579)

Acceptance Criteria (for WP Media team use only)

  1. New <style> tags should be in the <head> just after the <style id="wpr-lazyload-bg"></style>
  2. The error fixed in the Lazyload CSS background image compatibility issue with Chrome 119+ #6269 shouldn't occur
  3. No regressions in lazy loading the images
@piotrbak piotrbak added type: bug Indicates an unexpected problem or unintended behavior priority: high Issues which should be resolved as quickly as possible needs: grooming severity: minor Defect that does not affect functionality module: lazyload background css images labels Jan 3, 2024
@piotrbak piotrbak added this to the 3.15.7 milestone Jan 3, 2024
@Miraeld Miraeld self-assigned this Jan 4, 2024
Miraeld added a commit that referenced this issue Jan 4, 2024
@Miraeld
Closes #6360: Fix the markup problem
ea08579
@Miraeld Miraeld mentioned this issue Jan 4, 2024
Merged
8 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 4, 2024
@Miraeld
Closes #6360: Fix ll bgcss markup (#6362)
110e7c6
wordpressfan pushed a commit that referenced this issue Mar 15, 2024
@Miraeld @wordpressfan
Closes #6360: Fix ll bgcss markup (#6362)
1aba847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Miraeld Miraeld

Labels
module: lazyload background css images priority: high Issues which should be resolved as quickly as possible severity: minor Defect that does not affect functionality type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.15.7
Development

Successfully merging a pull request may close this issue.

Closes #6360: Fix ll bgcss markup wp-media/wp-rocket
2 participants
@Miraeld @piotrbak