-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong LCP type captured in the DB #6552
Milestone
Comments
@MathieuLamiot Yes I think it could be when modifying the beacon script because right now I see that the type is hardcoded here:
But as of right now, I see that the beacon script captures the single background image. |
Ok, so let's fix this for single background images. |
Miraeld
added a commit
that referenced
this issue
Apr 16, 2024
The type was hardcoded as `img`, now it becomes dynamic and set by the `lcp-beacon.js` script.
14 tasks
14 tasks
Miraeld
added a commit
that referenced
this issue
Apr 17, 2024
The type was hardcoded as `img`, now it becomes dynamic and set by the `lcp-beacon.js` script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Before submitting an issue please check that you’ve completed the following steps:
Describe the bug
When a background image is identified as the LCP, the type in the DB reads
img
To Reproduce
Steps to reproduce the behavior:
img
Expected behavior
We should capture background image LCP as
bg-img
instead ofimg
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming
The text was updated successfully, but these errors were encountered: