Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1514 Use preg_replace to insert the combined CSS tag #1696

Merged
merged 8 commits into from May 9, 2019

Conversation

Projects
None yet
2 participants
@Tabrisrp
Copy link
Contributor

commented May 7, 2019

Also fixes #1547

@Tabrisrp Tabrisrp added this to the 3.3.3 milestone May 7, 2019

@Tabrisrp Tabrisrp requested a review from Screenfeed May 7, 2019

@Tabrisrp Tabrisrp self-assigned this May 7, 2019

Tabrisrp added some commits May 7, 2019

@@ -1,8 +1,6 @@
<?php
namespace WP_Rocket\Admin;
defined( 'ABSPATH' ) || die( 'Cheatin&#8217; uh?' );

This comment has been minimized.

Copy link
@Screenfeed

Screenfeed May 9, 2019

Contributor

This should not be removed.
A direct access to the file will print a fatal error leading to a path disclosure:

Fatal error: Class 'WP_Rocket\Admin\Abstract_Options' not found in /abs/path/to/inc/classes/admin/class-options.php on line 10

@Screenfeed Screenfeed merged commit 476c83d into branch-3.3.3 May 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Screenfeed Screenfeed deleted the fix/1514-combine-css-title branch May 9, 2019

@Tabrisrp Tabrisrp referenced this pull request May 15, 2019

Merged

3.3.3 #1722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.