Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the never cache cookie textarea description #3457

Merged
merged 4 commits into from Jan 4, 2021
Merged

Change the never cache cookie textarea description #3457

merged 4 commits into from Jan 4, 2021

Conversation

engahmeds3ed
Copy link
Contributor

Fixes #3334

@engahmeds3ed engahmeds3ed self-assigned this Dec 31, 2020
@engahmeds3ed engahmeds3ed requested a review from a team December 31, 2020 17:41
@engahmeds3ed
Copy link
Contributor Author

@wp-media/qa ready for QA

@piotrbak piotrbak added this to the 3.8.2 milestone Dec 31, 2020
@piotrbak piotrbak linked an issue Dec 31, 2020 that may be closed by this pull request
Update Never Cache Cookies textarea description to explain partial matches are allowed #3334
Closed
@piotrbak piotrbak self-requested a review January 4, 2021 13:38
piotrbak
piotrbak approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@piotrbak piotrbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected. There's a JS error from Beacon in the console and it's not loading the Help article. That's because it's not published yet:
https://docs.wp-rocket.me/article/1382-never-cache-cookies

testrail-report-96.pdf

@Tabrisrp Tabrisrp added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement and removed needs: qa labels Jan 4, 2021
@Tabrisrp Tabrisrp merged commit 247f1e3 into develop Jan 4, 2021
@Tabrisrp Tabrisrp deleted the fix/3334-change-cookies-textarea-description branch January 4, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabrisrp Tabrisrp Tabrisrp left review comments

@iCaspar iCaspar iCaspar approved these changes

@piotrbak piotrbak piotrbak approved these changes

Assignees

@engahmeds3ed engahmeds3ed

Labels
Module: dashboard type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.8.2
Development

Successfully merging this pull request may close these issues.

Update Never Cache Cookies textarea description to explain partial matches are allowed
4 participants
@engahmeds3ed @Tabrisrp @iCaspar @piotrbak