Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hubspot iframe inline JS exclusion from combine JS #3943

Merged
merged 1 commit into from Jun 1, 2021
Merged

Add Hubspot iframe inline JS exclusion from combine JS #3943

merged 1 commit into from Jun 1, 2021

Conversation

NataliaDrause
Copy link
Contributor

@NataliaDrause NataliaDrause commented May 24, 2021 •
edited

Description

Fixes a broken Hubspot iframe.
Related ticket: https://secure.helpscout.net/conversation/1517369011/265005?folderId=3864740

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Customer tested on their site.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tabrisrp Tabrisrp added module: combine JS type: enhancement Improvements that slightly enhance existing functionality and are fast to implement labels Jun 1, 2021
@Tabrisrp Tabrisrp added this to the 3.9.0.1 milestone Jun 1, 2021
@Tabrisrp Tabrisrp merged commit 996a8c4 into develop Jun 1, 2021
@Tabrisrp Tabrisrp deleted the fix/exclude-inline-JS-hubspot branch June 1, 2021 18:20
crystinutzaa pushed a commit that referenced this pull request Jun 3, 2021
@Tabrisrp @engahmeds3ed
@mostafa-hisham @NataliaDrause @GeekPress
3.9.0.1 (#3986)
48f5466 
* Fixes #3478 Enable installation through composer v2 (PR #3928)

* update woocommerce from wpackagist
* update woocommerce paths
* use composer v2 in GH actions

* Re-add change to remove disable preload fonts when CPCSS is enabled (PR #3927)

* remove callback disabling preload fonts
* remove associated tests

* Stop preload while prewarmup is running (PR #3925)

* start automatic preload just after prewarmup finishes its work
* Block manual preload till finishing prewarmup
* check the RUCSS option enabled along with allow_optimization
* fix old tests
* [WIP] stop preload with enabling RUCSS
* migrate maybe_cancel_preload to RUCSS admin subscriber
* fix old tests

* remove charset=UTF-8 (PR #3946)

* remove charset=UTF-8
* remove charset=UTF-8 from delete

* Add unit tests code coverage (PR #3922)

* add code coverage command
* update incorrect annotations
* add cove coverage action
* enable xdebug for coverage

* Fix failing tests related to adding prewarmup functionality (PR #3949)

* Guard our code by checking if table is exists before updating prewarmup
* With switch_theme only start scanner when RUCSS is enabled

* change trigger event to push

* Fixes RUCSS tests: update time to prevent tests failures (PR #3973)

* Fixes #3600 add wpstage to staging servers list (PR #3948)

* add wpstage to staging servers

* remove image optimization when WP_ROCKET_WHITE_LABEL_ACCOUNT (PR #3956)

* remove image optimization menu when WP_ROCKET_WHITE_LABEL_ACCOUNT is used

* Add Hubspot iframe inline JS exclusion from combine JS (PR #3943)

* Fixes #3945 Display warning when WP Meteor is enabled with WP Rocket delay JS (PR #3974)

* add new add_plugins_incompatibility() method
* add options class to settings class dependencies
* updating existing tests
* add add_plugins_incompatibility() test file
* add unit & integration tests

* Fixes #3924 Remove unnecessary more info link in RUCSS pre-warmup copy (PR #3981)

* Compatibility with Impreza theme (PR #3972)

* Add Impreza inline script pattern to exclude
* Add Fixtures

Co-authored-by: Rémy Perona <remperona@gmail.com>

* Update delay JS script (PR #3971)

* update delay JS script
* update delay JS fixture
* add touchchancel and touchforcechange events
* update fixture with new events

* Fixes #2876 Remove beacon button when white label is enabled (PR #3965)

* remove beacon btn if white label is true
* remove ask support button too

* Add additional delay JS exclusions (PR #3975)

* Add additional exclusions from delay JS
* Update fixtures

* update plugin version to 3.9.0.1

* update operator in version_compare

Co-authored-by: Ahmed Saed <eng.ahmeds3ed@gmail.com>
Co-authored-by: mostafa-hisham <mostafa.hisham.mahmoud@gmail.com>
Co-authored-by: Natalia Drause <60236665+NataliaDrause@users.noreply.github.com>
Co-authored-by: Jonathan Buttigieg <jonathan@wp-media.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabrisrp Tabrisrp Tabrisrp approved these changes

Assignees

@NataliaDrause NataliaDrause

Labels
module: combine JS type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.9.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NataliaDrause @Tabrisrp