Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude inline JS from combine JS to avoid cache dir size issue #4349

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

alfonso100
Copy link
Contributor

Description

Cache dir size related exclusion per ticket:
https://secure.helpscout.net/conversation/1624925580/293183?folderId=377611#thread-4738760215

Fixes #(issue number)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which improves an existing functionality)

How Has This Been Tested?

On the customer site

Checklist:

Please delete the options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@Tabrisrp Tabrisrp added 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: combine JS type: enhancement Improvements that slightly enhance existing functionality and are fast to implement labels Oct 1, 2021
@Tabrisrp Tabrisrp changed the title New Exclusion to prevent cache dir size issues Exclude inline JS from combine JS to avoid cache dir size issue Oct 1, 2021
@Tabrisrp Tabrisrp merged commit d5eda82 into develop Oct 1, 2021
@Tabrisrp Tabrisrp deleted the exclude-inline-js-dir-size branch October 1, 2021 18:57
@Tabrisrp Tabrisrp mentioned this pull request Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: combine JS type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants