Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Beta" to RUCSS UI Button #4412

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Add "Beta" to RUCSS UI Button #4412

merged 1 commit into from
Oct 8, 2021

Conversation

iCaspar
Copy link
Contributor

@iCaspar iCaspar commented Oct 7, 2021 •
edited
Loading

Description

Per conversation in Slack, adds "(BETA)" to RUCSS button in the Rocket UI.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality)

How Has This Been Tested?

Viewed locally in Rocket UI.

Checklist:

Please delete the options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@iCaspar iCaspar self-assigned this Oct 7, 2021
@iCaspar iCaspar requested a review from a team October 7, 2021 13:49
@iCaspar iCaspar added the type: enhancement Improvements that slightly enhance existing functionality and are fast to implement label Oct 7, 2021
@iCaspar
Copy link
Contributor Author

iCaspar commented Oct 7, 2021

@wp-media/qa Acceptance Criteria:

  • (BETA) messaging appears on the RUCSS activation button in the Rocket UI.

@Tabrisrp Tabrisrp requested a review from a team October 7, 2021 15:57
@piotrbak piotrbak removed the needs: qa label Oct 8, 2021
@Tabrisrp Tabrisrp merged commit 03ce80e into develop Oct 8, 2021
@Tabrisrp Tabrisrp deleted the fix/add-beta-to-rucss-button branch October 8, 2021 15:30
@piotrbak piotrbak added this to the 3.10.1 milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabrisrp Tabrisrp Tabrisrp approved these changes

@piotrbak piotrbak piotrbak approved these changes

Assignees

@iCaspar iCaspar

Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iCaspar @Tabrisrp @piotrbak