Fixes #4374 prevent PHP fatal error by adding guard clauses if preg_replace() fails in delay JS add script #4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrisrp
added
type: bug
iCaspar
approved these changes
Oct 8, 2021
|
@Tabrisrp Are we 100% sure that Shall we do any check there before assigning the value? Assigning null there causes fatal error. |
|
@piotrbak Yes at this point |
piotrbak
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add guard clauses if
preg_replace()fails inadd_delay_js_script(), to avoid passing anullvalue tomove_meta_charset_to_head()instead of a string.Fixes #4374
Type of change
Is the solution different from the one proposed during the grooming?
No grooming done
How Has This Been Tested?
Checklist:
Please delete the options that are not relevant.