Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude documentcloud.adobe.com/view-sdk/main.js from JS minify and combine #4421

Merged
merged 1 commit into from Oct 14, 2021
Merged

Exclude documentcloud.adobe.com/view-sdk/main.js from JS minify and combine #4421

merged 1 commit into from Oct 14, 2021

Conversation

alfonso100
Copy link
Contributor

@alfonso100 alfonso100 commented Oct 12, 2021 •
edited by Tabrisrp

Description

Exclude documentcloud.adobe.com/view-sdk/main.js from JS minify and combine.

Fixes #4420

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

On my test environment

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@Tabrisrp Tabrisrp added 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: combine JS module: minify JS type: bug Indicates an unexpected problem or unintended behavior labels Oct 14, 2021
@Tabrisrp Tabrisrp added this to the 3.10.1 milestone Oct 14, 2021
@Tabrisrp Tabrisrp merged commit fec6fa1 into develop Oct 14, 2021
@Tabrisrp Tabrisrp deleted the origin/fix-4420-adobe-pdf-api-embed-script branch October 14, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tabrisrp Tabrisrp Tabrisrp approved these changes

Assignees

@alfonso100 alfonso100

Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: combine JS module: minify JS type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.10.1
2 participants
@alfonso100 @Tabrisrp