Exclude js.afterpay.com from Minify JS #4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrisrp
added
module: minify JS
type: bug
Tabrisrp
approved these changes
Nov 24, 2021
…m-minify-js # Conflicts: # inc/Engine/Optimization/Minify/JS/AbstractJSOptimization.php
Mai-Saad
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Working as expected when using afterpay script at the body.
testrail-report-318.pdf
iCaspar
deleted the
fix/4214-exclude-afterpay-external-js-from-minify-js
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adding
js.afterpay.comto the defaults exclusion array inAbstractJSOptimization::get_excluded_external_file_path()Fixes #4214
Type of change
Please delete options that are not relevant.
Is the solution different from the one proposed during the grooming?
No
How Has This Been Tested?
on my test site
Checklist:
Please delete the options that are not relevant.