Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/4590 adjust rocketcdn pricing issue #4592

Merged
merged 4 commits into from Dec 16, 2021

Conversation

engahmeds3ed
Copy link
Contributor

Description

By mistake we changed esc_html_e to esc_html at this PR #4575 to fix phpcs errors but we forgot to add echo.

Fixes #4590

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which improves an existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Is the solution different from the one proposed during the grooming?

Please describe in this section if there is any change to the solution, and why.

How Has This Been Tested?

Open RocketCDN banner at CDN tab and u can see the pricing correctly.

Checklist:

Please delete the options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@engahmeds3ed engahmeds3ed self-assigned this Dec 16, 2021
@engahmeds3ed engahmeds3ed changed the base branch from develop to trunk December 16, 2021 16:35
Copy link

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected, failed test need maintenance or another PR (already not related to PR)
testrail-report-327.pdf
Note:
The following error appeared in debug.log once while exploratory.. will be great if we can guard against it. (Happened while upgrade from trunk which contains old settings, then enable all features and delete plugin, probably after cache home page)
PHP Fatal error: Uncaught TypeError: Argument 1 passed to WP_Rocket\Dependencies\Minify\JS::getOperatorsForRegex() must be of the type array, bool given, called in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/inc/Dependencies/Minify/JS.php on line 309 and defined in /var/www/new.rocketlabsqa.ovh/htdocs/wp-content/plugins/wp-rocket/inc/Dependencies/Minify/JS.php:461
debug_fatal.log

@engahmeds3ed engahmeds3ed merged commit 97275bd into trunk Dec 16, 2021
@engahmeds3ed engahmeds3ed deleted the fix/4590-adjust_rocketCDN_pricing_issue branch December 16, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RocketCDN UI: In WP Rocket 3.10.5 RocketCDN price is not displayed
3 participants