Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #3444 Added code to delete params files #5157

Closed
wants to merge 1 commit into from

Conversation

CrochetFeve0251
Copy link
Contributor

@CrochetFeve0251 CrochetFeve0251 commented Jun 17, 2022

Description

In this PR we fix a problem in the cache cleaning where params cache from homepage are not cleared when a post is updated.
This has been fixed by adding a check on folders starting with # and if some exist we delete them.

Fixes #3444

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Is the solution different from the one proposed during the grooming?

No.

How Has This Been Tested?

  • Manual Test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CrochetFeve0251 CrochetFeve0251 self-assigned this Jun 17, 2022
@CrochetFeve0251 CrochetFeve0251 added type: bug Indicates an unexpected problem or unintended behavior module: cache labels Jun 17, 2022
@CrochetFeve0251 CrochetFeve0251 requested a review from a team June 17, 2022 11:07
@CrochetFeve0251 CrochetFeve0251 marked this pull request as ready for review June 17, 2022 11:08
@Mai-Saad Mai-Saad self-requested a review October 16, 2023 09:14
@Mai-Saad
Copy link

Mai-Saad commented Oct 16, 2023

@CrochetFeve0251 Thanks for the PR. Can see the qs cache for home is deleted with cache qs, dedicated cache qs when edit home, adding a new post, updating a post, deleting a post, clear the cache of this URL in page list or purge this URL from page view. But clear used CSS for this URL will clear the cache of home but not the home qs cache. I think it shall be deleted in this case too @piotrbak @CrochetFeve0251 what do you think?

@piotrbak
Copy link
Contributor

Yes, it should be included.

@CrochetFeve0251
Copy link
Contributor Author

Closed in favor of #6234. (I moved the modifications to the new code as I spotted some problems due to old code)

@CrochetFeve0251 CrochetFeve0251 deleted the bug/3444-remove-param-dir branch October 19, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: cache type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query string version of the homepage is not cleared with rocket_clean_home
4 participants