Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update delayJS script and stop handling scripts inside svg #5731

Merged
merged 8 commits into from Feb 2, 2023

Conversation

CrochetFeve0251
Copy link
Contributor

Description

Updated lazyload JS script.

Fixes #5725

Type of change

Please delete options that are not relevant.

  • Bug

How Has This Been Tested?

  • Automated test

Checklist:

Please delete the options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CrochetFeve0251 CrochetFeve0251 changed the base branch from develop to trunk January 31, 2023 12:42
@CrochetFeve0251 CrochetFeve0251 marked this pull request as ready for review January 31, 2023 12:44
@CrochetFeve0251 CrochetFeve0251 requested a review from a team January 31, 2023 12:44
@piotrbak
Copy link
Contributor

piotrbak commented Jan 31, 2023

@wp-media/php For the 3.12.5.2 we'll also need to make sure that <script> inside < svg > is not rewritten to Delay JS.

Related convo:
https://wp-media.slack.com/archives/GUT7FLHF1/p1675189916149859

inc/Engine/Optimization/RegexTrait.php Outdated Show resolved Hide resolved
inc/Engine/Optimization/RegexTrait.php Outdated Show resolved Hide resolved
inc/Engine/Optimization/RegexTrait.php Outdated Show resolved Hide resolved
CrochetFeve0251 and others added 4 commits February 2, 2023 12:03
Co-authored-by: Michael Lee <38788055+jeawhanlee@users.noreply.github.com>
Co-authored-by: Michael Lee <38788055+jeawhanlee@users.noreply.github.com>
Co-authored-by: Michael Lee <38788055+jeawhanlee@users.noreply.github.com>
@engahmeds3ed engahmeds3ed merged commit a677439 into trunk Feb 2, 2023
@engahmeds3ed engahmeds3ed deleted the fix/5725-update-js-lazyload-trunk branch February 2, 2023 16:12
@engahmeds3ed engahmeds3ed changed the title Updated lazyload script Update delayJS script and stop handling scripts inside svg Feb 2, 2023
@charls637
Copy link

On firefox, when delayJS script is enabled.. links are not working A links and Nav links.. Using elementor.. btw chrome and other browser works fine.

@piotrbak
Copy link
Contributor

piotrbak commented Mar 9, 2023

@charls637 Hello and thanks for your comment. Are you using the latest, 3.12.6.1 version of WP Rocket?

If so, and you still experience this problem, please reach our Support.

@charls637
Copy link

image
Hello @piotrbak thank you for the fast response. I already submitted the ticket 5-6 hours ago.
Latest I can use is wp-rocket_3.12.5.3.zip.. I tried to download it from the account page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Delay JS script to the latest version
5 participants