Fixes #5762 warning undefined array key on theme rollback #5768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrochetFeve0251
approved these changes
Feb 17, 2023
|
Working fine while rollback/upgrade to theme(s)/plugins. Note: we may need to have GH to clear cache when we rollback active theme as we do when updating active theme. @piotrbak what do you think? |
Mai-Saad
approved these changes
Feb 28, 2023
Tabrisrp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
guard against Undefined array keys on theme rollback
Fixes #5762
Type of change
Is the solution different from the one proposed during the grooming?
No, but i did the check for action and type too
How Has This Been Tested?
Checklist: