Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable webp option when any webp plugin serves webp generation #5773

Merged
merged 1 commit into from Feb 22, 2023

Conversation

engahmeds3ed
Copy link
Contributor

Description

This is a regression found by @Mai-Saad so we need to make sure that we disable webp option when any supported webp plugin is serving webp images like Imagify.

@wp-media/productrocket I don't know if we need to handle the following case also here or not:

  1. Deactivate Imagify
  2. Enable Webp option in WPR
  3. Enable Imagify
  4. The option is disabled but in ON mode

I think this should be in OFF mode, what do u think?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally

Checklist:

Please delete the options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@engahmeds3ed engahmeds3ed self-assigned this Feb 21, 2023
@engahmeds3ed engahmeds3ed marked this pull request as ready for review February 21, 2023 19:20
@engahmeds3ed engahmeds3ed requested a review from a team February 21, 2023 19:20
@engahmeds3ed engahmeds3ed added this to the 3.12.6 milestone Feb 21, 2023
@Mai-Saad Mai-Saad self-requested a review February 22, 2023 06:34
Copy link

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected with the following note:

  • if WPR Addon was on , before serving WebP from the compatibility plugin, once serving WebP from the other plugin, our Addon will be off and dimmed, If we disabled the other plugin or stopped serving WebP there, our Addon will be enabled and Off. (already on trunk)
    testrail-report-452.pdf

@Mai-Saad Mai-Saad added this pull request to the merge queue Feb 22, 2023
Merged via the queue into develop with commit 0dd1e1f Feb 22, 2023
@Mai-Saad Mai-Saad deleted the hotfix/webp_disable_option_with_webp_plugins branch February 22, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants