New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken layout when title tag is missed from the page #5790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrisrp
approved these changes
Mar 7, 2023
@engahmeds3ed Thanks for the PR. the problem is fixed for RUCSS but not Combine CSS. Can you please have a look? |
@engahmeds3ed Could you take a look at this one? |
@engahmeds3ed Is it ready for review? |
Mai-Saad
approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected
testrail-report-483.pdf
Note:
- if in previous version we have broken URLs in Used CSS table, it will still be there till manual clear used after update to PR but it won't be applied on FE once cache is cleared
vmanthos
added
the
needs: documentation
Issues which need to create or update a documentation
label
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here we are keeping CSS in its place if we found that the page doesn't contain title tag.
Fixes #5755
Type of change
Please delete options that are not relevant.
Is the solution different from the one proposed during the grooming?
No, it's as groomed.
How Has This Been Tested?
Checklist:
Please delete the options that are not relevant.