Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken layout when title tag is missed from the page #5790

Merged
merged 8 commits into from May 12, 2023

Conversation

engahmeds3ed
Copy link
Contributor

@engahmeds3ed engahmeds3ed commented Mar 2, 2023

Description

Here we are keeping CSS in its place if we found that the page doesn't contain title tag.

Fixes #5755

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which improves an existing functionality)

Is the solution different from the one proposed during the grooming?

No, it's as groomed.

How Has This Been Tested?

  • Integration test
  • Locally: manual test

Checklist:

Please delete the options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@engahmeds3ed engahmeds3ed self-assigned this Mar 2, 2023
@engahmeds3ed engahmeds3ed marked this pull request as ready for review March 7, 2023 12:41
@Mai-Saad Mai-Saad self-requested a review March 28, 2023 09:12
@Mai-Saad
Copy link

@engahmeds3ed Thanks for the PR. the problem is fixed for RUCSS but not Combine CSS. Can you please have a look?

@piotrbak
Copy link
Contributor

piotrbak commented Apr 9, 2023

@engahmeds3ed Could you take a look at this one?

@piotrbak
Copy link
Contributor

piotrbak commented May 7, 2023

@engahmeds3ed Is it ready for review?

Copy link

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected
testrail-report-483.pdf
Note:

  • if in previous version we have broken URLs in Used CSS table, it will still be there till manual clear used after update to PR but it won't be applied on FE once cache is cleared

@Mai-Saad Mai-Saad added this pull request to the merge queue May 12, 2023
Merged via the queue into develop with commit 0df2f92 May 12, 2023
7 checks passed
@Mai-Saad Mai-Saad deleted the fix/5755-RUCSS_no_title_tag branch May 12, 2023 13:51
@vmanthos vmanthos added this to the 3.13.3 milestone May 22, 2023
@vmanthos vmanthos added the needs: documentation Issues which need to create or update a documentation label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: documentation Issues which need to create or update a documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If <title> tag is missing from the source, Used CSS code is not delivered, causing broken layout
5 participants