Fixed disappearing notice Cloudflare

[CrochetFeve0251]

Description

Fix an issue with the error disappearing if we save the page without changing any value.

For that we fixed a couple of errors and change the check for the error to the pre_update filter.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally

Checklist:

Please delete the options that are not relevant.

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[Mai-Saad]

@CrochetFeve0251 Thanks for the update. Saving the settings while the error is displayed won't hide the error. However, please find exploratory test notes below:

• Refreshing the page while the error is displayed, will hide the error. => Shouldn't the error still be displayed here?
• If we have 3.14, where the error was hidden due to the bug there, then we update to the PR, shouldn't the error be displayed? (currently, it is not)

[CrochetFeve0251]

@CrochetFeve0251 Thanks for the update. Saving the settings while the error is displayed won't hide the error. However, please find exploratory test notes below:

• Refreshing the page while the error is displayed, will hide the error. => Shouldn't the error still be displayed here?
• If we have 3.14, where the error was hidden due to the bug there, then we update to the PR, shouldn't the error be displayed? (currently, it is not)

@Mai-Saad the error is displayed when we save so it is normal if we don't save anything.
Are we supposed to display an error even nothing is currently saved?

[Mai-Saad]

@CrochetFeve0251 As per discussion with @piotrbak nothing is needed here and fine as is.

[Mai-Saad]

testrail-report-494.pdf
Working as expected with the following note (agreed to remain as is)
The 1st time we save settings while having wrong CF addon data + CF plugin is on and authenticated => validation error is displayed and any other save settings after that won't show the error